Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workspace from a node #642

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Conversation

Zulalm
Copy link
Contributor

@Zulalm Zulalm commented Dec 19, 2023

A menu is added to the node details page. This menu contains only one button to create new workspace from an existing node.
For now, this menu is visible to only authenticated users. I will change it to be visible to only contributors and reviewers, after merging this PR.

@Zulalm Zulalm added size: small Can be completed quickly and without significant effort. type: implementation This issue is related to implementation frontend labels Dec 19, 2023
@Zulalm Zulalm self-assigned this Dec 19, 2023
@laylaylo laylaylo self-requested a review December 19, 2023 12:25
Copy link
Contributor

@laylaylo laylaylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some interesting confusion between this PR and annotation PR, let's try to merge conflicts again.

@laylaylo
Copy link
Contributor

Nice work!

Copy link
Contributor

@omerfaunal omerfaunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked together in the lab. Everything is OK now

@Zulalm Zulalm merged commit 118dd1f into frontend Dec 19, 2023
@Zulalm Zulalm deleted the 611-fe-create-workspace-from-a-node branch December 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend size: small Can be completed quickly and without significant effort. type: implementation This issue is related to implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants