Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

596 fe add review feature to workspace page #644

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Zulalm
Copy link
Contributor

@Zulalm Zulalm commented Dec 19, 2023

  • Users can send their workspaces to review.
  • Review workspaces section is added to workspaces sidebar. But it displays only mock data.
  • Review button is added.
  • A popup is implemented to add comments to review.
    Remaining Issues
  • Send review should be functional.
  • Workspaces side bar should be connected to database.
  • Reviewed workspaces should not be editable.

@@ -3,6 +3,7 @@ import 'package:collaborative_science_platform/models/user.dart';
import 'package:collaborative_science_platform/models/workspaces_page/entry.dart';

enum WorkspaceStatus {finalized, workable, inReview, published, rejected}
enum RequestStatus { approved, rejected, pending }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always good to use enums. Nice job

@laylaylo laylaylo requested review from laylaylo and removed request for mehmetSuzer December 19, 2023 12:40
Copy link
Contributor

@laylaylo laylaylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice structure, first finalizing workspace and then sending to review!

@laylaylo laylaylo merged commit b429957 into frontend Dec 19, 2023
@Zulalm Zulalm deleted the 596-fe-add-review-feature-to-workspace-page branch December 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants