Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

647 fe you may like return related nodes #693

Merged
merged 2 commits into from
Dec 25, 2023
Merged

647 fe you may like return related nodes #693

merged 2 commits into from
Dec 25, 2023

Conversation

omerfaunal
Copy link
Contributor

@omerfaunal omerfaunal commented Dec 24, 2023 •
edited

In the node view pages "you may like" part should show related (similar semantic tags) nodes.

@omerfaunal omerfaunal self-assigned this Dec 24, 2023
@omerfaunal omerfaunal linked an issue Dec 24, 2023 that may be closed by this pull request
FE - You May Like Return Related Nodes #647
Closed
2 tasks
@omerfaunal omerfaunal changed the base branch from main to frontend December 24, 2023 11:21
@omerfaunal omerfaunal removed the request for review from laylaylo December 24, 2023 11:21
Zulalm
Zulalm requested changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@Zulalm Zulalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search bar does not work on the home page. Also, random nodes is not shown.
image
"you may like" section includes related nodes but when I navigate between nodes on that section, nodes are not refreshed. New nodes are added to the existing nodes. It causes showing duplicate and unrelated nodes.

@omerfaunal
Copy link
Contributor Author

Search bar does not work on the home page. Also, random nodes is not shown. image "you may like" section includes related nodes but when I navigate between nodes on that section, nodes are not refreshed. New nodes are added to the existing nodes. It causes showing duplicate and unrelated nodes.

Thank you for your feedback. After reviewing your comments, I have made necessary corrections and addressed some oversights. Still, the primary issue lies on the backend side. I have already alerted them about the error.

Zulalm
Zulalm approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@Zulalm Zulalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Zulalm Zulalm merged commit 1ddf7d9 into frontend Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zulalm Zulalm Zulalm approved these changes

Assignees

@omerfaunal omerfaunal

Labels
frontend
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging this pull request may close these issues.

FE - You May Like Return Related Nodes
2 participants
@omerfaunal @Zulalm