Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user semantic tag add/remove implemented #711

Merged
merged 10 commits into from
Dec 25, 2023
Merged

user semantic tag add/remove implemented #711

merged 10 commits into from
Dec 25, 2023

Conversation

hakanaktas0
Copy link
Contributor

@hakanaktas0 hakanaktas0 commented Dec 25, 2023 •
edited

This PR includes:

  1. additional checks for workspace semantic tag add/remove API
  2. Implementation of User semantic tag add/remove API
  3. Semantic Tag serializer for NodeViewAPI
  4. is_disproof field of set_proof api is omitted.

@hakanaktas0 hakanaktas0 self-assigned this Dec 25, 2023
@hakanaktas0 hakanaktas0 added the backend issues related to backend label Dec 25, 2023
Simurgan
Simurgan approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@Simurgan Simurgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good, good job bro

@hakanaktas0 hakanaktas0 merged commit a43fbc7 into backend Dec 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simurgan Simurgan Simurgan approved these changes

Assignees

@hakanaktas0 hakanaktas0

Labels
backend issues related to backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakanaktas0 @Simurgan