Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE - Image annotation #732

Merged
merged 2 commits into from
Dec 28, 2023
Merged

BE - Image annotation #732

merged 2 commits into from
Dec 28, 2023

Conversation

Bera0422
Copy link
Contributor

This PR includes the backend implementation for handling the image annotations.
This PR fixes #731

@Bera0422
Update models and API methods
67136f6 
Added TextPositionSelector and FragmentSelector models as children of the Selector model.

Updated serializer and POST methods to incorporate the image annotations.
@Bera0422
Write Tests
207e065 
I have implemented a test case for getting an image annotation.

I also fixed a bug related to the type field of annotation target.
@Bera0422 Bera0422 added priority: high This issue should be addressed as soon as possible. size: medium Requires moderate effort and may take several days to a week to complete. difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete type: implementation This issue is related to implementation backend issues related to backend labels Dec 28, 2023
@Bera0422 Bera0422 self-assigned this Dec 28, 2023
@Bera0422 Bera0422 changed the title Be image annotation BE - Image annotation Dec 28, 2023
Simurgan
Simurgan approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@Simurgan Simurgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working

@Bera0422 Bera0422 merged commit 27a19ec into backend Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simurgan Simurgan Simurgan approved these changes

@hakanaktas0 hakanaktas0 Awaiting requested review from hakanaktas0

Assignees

@Bera0422 Bera0422

Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: high This issue should be addressed as soon as possible. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bera0422 @Simurgan