Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for login, signup function also cleared up the functions #199

Merged
merged 3 commits into from
May 15, 2024

Conversation

ahmetfirat23
Copy link
Contributor

I have written unit tests for login and signup. I only covered cases that are not handled in frontend. Also made some clearing in the functions too. Please make sure to understand the changes in the functions before accepting. Also please work from here on authentication.

@ahmetfirat23 ahmetfirat23 added Status: Review Needed Requires assessment or approval from team members Component: Backend Issues related to server-side logic or infrastructure Priority: Urgent This issue needs to be resolved immediately labels May 13, 2024
@ahmetfirat23 ahmetfirat23 added this to the Milestone 4 milestone May 13, 2024
@ahmetfirat23 ahmetfirat23 self-assigned this May 13, 2024
Copy link
Contributor Author

@ahmetfirat23 ahmetfirat23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine now

@ahmetfirat23
Copy link
Contributor Author

I updated since I was asking to delete all previous work sry

Copy link
Contributor

@isilsukarakuzuu isilsukarakuzuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With new change, lgtm!

backend/main/views.py Show resolved Hide resolved
@ahmetfirat23 ahmetfirat23 merged commit 372cf2b into backend-dev May 15, 2024
@ahmetfirat23 ahmetfirat23 deleted the backend/login-sign-up-unit-tests branch May 15, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Issues related to server-side logic or infrastructure Priority: Urgent This issue needs to be resolved immediately Status: Review Needed Requires assessment or approval from team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants