Skip to content

Commit

Permalink
Run ipc_server_with_database example in CI again
Browse files Browse the repository at this point in the history
Running test binaries with different argv[0] names seems to not work
sometimes, so I disabled it, but I realized we can just run the example
manually in the Makefile.
  • Loading branch information
boustrophedon committed Apr 11, 2024
1 parent adbb1cb commit fa738bc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ test-ci:
cargo test --target=$(TARGET_TRIPLE) --tests --examples --all-features
cargo test --target=$(TARGET_TRIPLE) --tests --examples --no-default-features
cargo run --all-features --example isolate_test
cargo run --all-features --example ipc_server_with_database

# Run clippy
lint:
Expand Down
7 changes: 0 additions & 7 deletions examples/ipc_server_with_database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -407,10 +407,3 @@ fn main() {
db_child.kill().unwrap();
webserver_child.kill().unwrap();
}

// TODO: this test randomly doesn't complete in github CI. investigate later but disable for now
// since I don't think it's adding significant coverage compared to the non-ipc version.
//#[test]
//fn run_main() {
// main()
//}

0 comments on commit fa738bc

Please sign in to comment.