Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #8

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Update dependencies #8

merged 2 commits into from
Jun 1, 2023

Conversation

Kijewski
Copy link
Contributor

No description provided.

@boustrophedon
Copy link
Owner

Sorry for the delay in getting to these reviews. Everything looks good, I'm just trying to figure out how to get github actions to run on PRs without having them run automatically.

@Kijewski
Copy link
Contributor Author

No problem! If you want, I could have a look, too. I am using your project in https://github.com/Kijewski/pyextrasafe, and you could mostly just copy its ci.yml, just exclude the python specific rules (python-black + python-make).

@boustrophedon
Copy link
Owner

boustrophedon commented Jun 1, 2023

I updated some settings and enabled CI on PR. Could you test that it works by changing the comment above ctx.add_arch in this commit to something like

        // add_arch returns whether the arch has already been added.
        // Since this is a new context, it can be ignored.
        let _: bool = ctx.add_arch(ScmpArch::Native)?;

If it works and you see CI being run, I think you should be able to trigger it on the other PRs by doing something like git commit --amend --date=now and pushing.

Thanks!

@Kijewski
Copy link
Contributor Author

Kijewski commented Jun 1, 2023

I rebased my PRs on the new HEAD. Because I'm a new contributor to this project, you still need to push a button to run the CI. Once a commit of a user is accepted, all their subsequent workflow runs should start automatically.

@boustrophedon
Copy link
Owner

Whoops, the new contributors one was one of the settings I changed. It's running now.

@boustrophedon boustrophedon merged commit a73c4f6 into boustrophedon:master Jun 1, 2023
4 checks passed
@boustrophedon
Copy link
Owner

Thanks again! I'll check out pyextrasafe soon!

@Kijewski Kijewski deleted the pr-update-dependencies branch June 1, 2023 21:46
@Kijewski
Copy link
Contributor Author

Kijewski commented Jun 1, 2023

Thank you very much for your project and merging my PRs!

I don't know if pyextrasafe will be interesting for anyone but me.
I use extrasafe for all my rust projects: Read the configuration, open a TCP or Unix socket (development vs production), start up tokio, and then lock down everything. I know my program, won't need to open another file, another socket, etc.

In python you have to assume that the program reads files at random points, and starts threads randomly. But at least I can be sure that my program won't exfiltrate any data, because it won't open a file for writing or open a socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants