Merge pull request #2886 from boutproject/minor-fixes

Some minor fixes, docs, ...

.gitignore

@@ -85,3 +85,5 @@ coverage/
 /_version.txt
 /BOUT++-v*.tar.gz
 /BOUT++-v*.tar.xz
+/CMakeCache.txt
+/CMakeFiles/cmake.check_cache

include/bout/options.hxx

@@ -364,7 +364,8 @@ public:
   ///         {"long_name", "some velocity"}
   ///       });
   Options& setAttributes(
-      std::initializer_list<std::pair<std::string, Options::AttributeType>> attrs) {
+      const std::initializer_list<std::pair<std::string, Options::AttributeType>>&
+          attrs) {
     for (const auto& attr : attrs) {
       attributes[attr.first] = attr.second;
     }

include/bout/single_index_ops.hxx

@@ -16,7 +16,7 @@ using EXEC_POL = RAJA::cuda_exec<CUDA_BLOCK_SIZE>;
 using EXEC_POL = RAJA::loop_exec;
 #endif // end BOUT_USE_CUDA
 ////-----------CUDA settings------------------------------------------------------end
-#endif
+#endif // end BOUT_HAS_RAJA
 
 // Ind3D: i.zp():
 BOUT_HOST_DEVICE inline int i_zp(const int id, const int nz) {

include/bout/sundials_backports.hxx

@@ -3,7 +3,7 @@
 // These are common backports shared between the CVode, ARKode, and IDA solvers
 //
 // Copyright 2022 Peter Hill, BOUT++ Team
-// SPDX-License-Identifier: LGPLv3
+// SPDX-License-Identifier: LGPL-3.0-or-later
 
 #ifndef BOUT_SUNDIALS_BACKPORTS_H
 #define BOUT_SUNDIALS_BACKPORTS_H

include/bout/utils.hxx

@@ -362,6 +362,14 @@ public:
     return data[i.ind];
   }
 
+  T& operator[](Ind3D i) {
+    // ny and nz are private :-(
+    // ASSERT2(i.nz == n3);
+    // ASSERT2(i.ny == n2);
+    ASSERT2(0 <= i.ind && i.ind < n1 * n2 * n3);
+    return data[i.ind];
+  }
+
   Tensor& operator=(const T& val) {
     for (auto& i : data) {
       i = val;

src/mesh/fv_ops.cxx

@@ -22,7 +22,7 @@ Slices<T> makeslices(bool use_slices, const T& field) {
 
 namespace FV {
 
-// Div ( a Grad_perp(f) ) -- ∇⊥ ( a ⋅ ∇⊥ f) --  Vorticity
+// Div ( a Grad_perp(f) ) -- ∇ ⋅ ( a ∇⊥ f) --  Vorticity
 Field3D Div_a_Grad_perp(const Field3D& a, const Field3D& f) {
   ASSERT2(a.getLocation() == f.getLocation());