Include what we use (header tidy) #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the requirement to include the interpolation header
As we provide header guards for boutcomm we can avoid including mpi.h multiple times.
Just forward decls was breaking physics models, but physicsmodel.hxx must be included for BOUTMAIN, so reasonable for this header to be the minimal needed?
|
As expected, this has a million conflicts. Given my changes were either from a tool or basically just mechanical, I'm closing this and will revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1464. Done automatically using include-what-you-use plus some manual tinkering. I can add the mapping file I used, but it has hardcoded absolute paths in it.
""when including our headersclang-formatto sort headersThis is an enormous change, but it should be entirely backwards compatible --
bout/physicsmodel.hxxincludes more headers than it actually needs in order to maintain this.The compilation speedup is about 20%, but it does also make all our headers consistent (albeit using a sledgehammer!)
I think we should do this at some point, along with moving all the headers inside
include/bout/, but we could put both off till 5.0. They can (mostly) be done automatically now too, so it's not a great effort to re-do at a later point.