Update examples/staggered_grid for v4.2 #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, probably makes sense to go into master as well. I wonder if it would be possible to "deprecate" options set in the wrong section? Something like |
ZedThree
previously approved these changes
Mar 20, 2019
Stricter checking on staggered grid functionality had broken this example.
johnomotani
force-pushed
the
fix_example_staggered_grid
branch
from
8f70d36
to
87c16bc
Compare
ZedThree
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter checking on staggered grid functionality had broken this example.
Thanks to @Jmbols for finding this.
Should this go into
masterinstead? Not sure if errors in examples count as 'bugs'. Should be trivial to re-base.