Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative paths to be followed when making #1670

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

johnomotani
Copy link
Contributor

Update the makefile recipe to keep the path when compiling. This may be useful when user code is in several directories.

Using @F:.o=.cxx removes the path, leaving just the file-name. Using @:.o=.cxx instead allows using a relative path in SOURCEC entries in user makefiles, making it easier to split some code (e.g. shared between more than one physics model) into a separate directory.

The @F has been there since the initial commit to git, so I can't find any record of why it was there.

I've made this PR into master because I'd like to be able to use the shared-directory thing in 'release' code now-ish, but I could wait to make the update if anyone's not sure it's appropriate to go into master.

Update the makefile recipe to keep the path when compiling. This may be
useful when user code is in several directories.
@johnomotani johnomotani added the small-change Changes less than 100 lines - should be quick to review label Apr 7, 2019
@johnomotani
Copy link
Contributor Author

Thanks @d7919 for telling me where to make the change!

@ZedThree ZedThree merged commit 3062e3a into master Apr 8, 2019
@ZedThree ZedThree deleted the make-allow-relative-paths branch April 8, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants