ensure make clean cleans tests #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `make clean check` does not force a rebuild of the tests, which can cause confusion, as it hides or causes bugs. Further as we are printing before cleaning, it should be cleaning rather then cleaned.
|
Something else is needed too -- this does now run |
Previously the tests didn't add the directories to be cleaned, and thus the clean in the tests didn't do anything.
|
should be fixed now, but not sure it is needed, if we switch to cmake ... edit: note you need to run configure for this change to be effective. |
ZedThree
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
make clean checkdoes not force a rebuild of the tests,which can cause confusion, as it hides or causes bugs. (potentially #1665 )
Further as we are printing before cleaning, it should be 'cleaning'
rather then 'cleaned'.