Construct Option with initializer_list #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables initializer lists to be used to create custom options, to pass to solvers or other components. This is a slightly more compact way to create options trees than the existing method. Unfortunately requires non-template constructors for the accepted types, but these are quite simple. Includes tests and documentation.
johnomotani
previously approved these changes
Jul 23, 2019
ZedThree
reviewed
Jul 24, 2019
|
Codacy would like both these constructors to be |
ZedThree
approved these changes
May 26, 2020
|
Thanks @bendudson ! Very sorry this took such a long time to deal with! 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables initializer lists to be used to create custom options, to pass to solvers or other components. This is a slightly more compact way to create options trees than the existing method.
Unfortunately requires non-template constructors for the accepted types, but these are quite simple.Includes tests and documentation.