Add counters to Timers to avoid double-counting sections #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplements some of #1658 in master Reference counting Timers turns out to be necessary or nested timers with the same name will end up double counting the section. Currently, this results in the "Inv" timer report in the default monitor being twice as large as it really is.
ZedThree
added
bugfix
small-change
d7919
reviewed
Oct 22, 2019
johnomotani
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements some of #1658 in master
Reference counting Timers turns out to be necessary or nested timers
with the same name will end up double counting the section. Currently,
this results in the "Inv" timer report in the default monitor being
twice as large as it really is.