Fix various warnings #1832
Merged
Fix various warnings #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely not a real problem: the issue is if someone uses the derived class concretely (i.e. _not_ through a pointer to the base class), then some of the overloads of virtual methods may be hidden.
Note about reinterpret_cast: there are three different situations here that require reinterpret_cast over static_cast: - cast to void**: this is solely for context objects that PETSc stores but does not touch, so completely fine (assuming we're consistent ourselves) - function pointer cast: this is required because PETSc deliberately takes the _wrong_ function signature for reasons?! This is fine assuming the actual function signature matches how PETSc calls the function - cast to PetscObject: this is because PETSc has reinvented C++ in C, and this is essentially a cast to base-class pointer. This is fine assuming we pass something that has a PetscObject as its first member -- read the documentation or source code to find out!
Should deprecate and remove this function!
bendudson
reviewed
Nov 4, 2019
bendudson
reviewed
Nov 4, 2019
bendudson
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warnings on gcc:
There are >300 warnings from our use of
intinstead ofsize_tin lots of places. I'm not a huge fan of unsigned types, but seeing as the standard library does use them, we might be better off switching to use them. There's probably a few places where it's not as simple as just changing the type, and we'd have to make other changes, but the majority of places are likely fine.