-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining integrated tests to CMake build #1833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test checks that FieldGroup(int) doesn't compile: this can now be done via std::is_constructable
_very_ difficult to reproduce, probably rounding error
This is consistent with the existing Makefile approach and removes the need for EXECUTABLE_NAME
Codecov Report
@@ Coverage Diff @@
## next #1833 +/- ##
=====================================
Coverage 34.1% 34.1%
=====================================
Files 187 187
Lines 22689 22689
=====================================
Hits 7737 7737
Misses 14952 14952 Continue to review full report at Codecov.
|
bendudson
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few other CMake fixes.
There are a few small non-CMake related changes here that made sense to make in this PR, but they could be pulled out:
make
: a small number of tests either callmake clean
or justrm ./test_name
before callingmake
. This is probably redundant and we don't do it consistently. It also happens to interfere with runningmake check
in CMake buildstest-datadir
with two subtests intest-command-args
: this test was essentially just testing the-d
command line argument works.test-command-args
tests the other arguments, so it makes sense to combine themtest-fieldgroup
with a couple of unit tests. This test tries to check that some expression is ill-formed. This can be replaced withstd::is_constructable
test-fieldgroupcomm
: very minor change, just for consistency really.