Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining integrated tests to CMake build #1833

Merged
merged 22 commits into from
Nov 22, 2019
Merged

Add remaining integrated tests to CMake build #1833

merged 22 commits into from
Nov 22, 2019

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Nov 5, 2019

Plus a few other CMake fixes.

There are a few small non-CMake related changes here that made sense to make in this PR, but they could be pulled out:

  • Don't delete test executables before calling make: a small number of tests either call make clean or just rm ./test_name before calling make. This is probably redundant and we don't do it consistently. It also happens to interfere with running make check in CMake builds
  • Two small fixes for the PETSc Laplace MAST test: it was always using the same grid file, and it sometimes required one more iteration than the max iterations
  • Replace test-datadir with two subtests in test-command-args: this test was essentially just testing the -d command line argument works. test-command-args tests the other arguments, so it makes sense to combine them
  • Replace test-fieldgroup with a couple of unit tests. This test tries to check that some expression is ill-formed. This can be replaced with std::is_constructable
  • Use the default executable name in test-fieldgroupcomm: very minor change, just for consistency really.

@ZedThree ZedThree added this to the BOUT-5.0 milestone Nov 5, 2019
Previously changed test in fab7328 to not copy+sed input file, forgot
that the input file in data/ wasn't in repo
Previously changed test in fab7328 to not copy+sed input file, forgot
that the input file in data/ wasn't in repo (again)
@codecov-io
Copy link

Codecov Report

Merging #1833 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #1833   +/-   ##
=====================================
  Coverage   34.1%   34.1%           
=====================================
  Files        187     187           
  Lines      22689   22689           
=====================================
  Hits        7737    7737           
  Misses     14952   14952

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52eba6...a3a6c44. Read the comment docs.

@ZedThree ZedThree merged commit f51c655 into next Nov 22, 2019
@ZedThree ZedThree deleted the more-cmake branch November 22, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants