Remove deprecated Laplacian API #1834
Conversation
ZedThree
added
the
breaking change
|
|
||
| low_mem = (*options)["low_mem"] | ||
| .doc("If true, reduce the amount of memory used") | ||
| .withDefault(false); |
There was a problem hiding this comment.
It looks like low_mem is only actually implemented now by LaplacePDD. If we remove that (#1828) we can remove the option too.
| } | ||
| int flags = (*options)["flags"] | ||
| .doc("Flags to control inner and outer boundaries.") | ||
| .withDefault(0); |
There was a problem hiding this comment.
I agree with removing this option in v5, but it might be a good idea to put a deprecation warning on use of the laplace:flags option in v4.3.1/v4.4. I can't think of anything better than printing a message to output_warn here, which isn't very noticable, but better than nothing...
There was a problem hiding this comment.
Good idea! I think there's a few options we'd like to deprecate like this too, although none spring to mind right now.
| OPTION(options, inner_boundary_flags, 0); | ||
| OPTION(options, outer_boundary_flags, 0); | ||
| } | ||
| global_flags = (*options)["global_flags"].doc("Default flags").withDefault(0); |
There was a problem hiding this comment.
"Default flags" seems a bit vague, although I'm struggling to come up with something more descriptive - maybe something like "Flags to set Laplace solver options (apart from boundary conditions)"?
There was a problem hiding this comment.
Very true. I just took the docstring from the header.
No description provided.