Fix typo in initialisation of rgn_outer_x #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use lastX() check instead of firstX() when initialising rgn_outer_x
bendudson
approved these changes
Nov 11, 2019
|
Probably should go into master branch too |
|
Failing tests are just due to missing coverage token |
|
I'll cherry-pick into master now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rgn_outer_x will contain the outer x guard cells of the first processors in x rather than the outer boundary cells from the last x processors unless the domain is periodic in x.
I don't think this is the intended behaviour so this pull request switches the firstX() check for lastX() when initialising the region.
Addresses #1836