Implement toFieldAligned and fromFieldAligned for Vector3D #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
added
feature
small-change
|
Should we also add it for Also, you can drop the |
bendudson
reviewed
Jan 10, 2020
src/field/vector3d.cxx
Outdated
| Vector3D result; | ||
| result.setLocation(v.getLocation()); | ||
| if (not v.covariant) { | ||
| result.toContravariant(); |
There was a problem hiding this comment.
We probably should have an emptyFrom and zeroFrom for vectors, like for fields.
bendudson
previously approved these changes
Jan 10, 2020
These are null operations for the Field2D components of Vector2D, so they just return a copy.
ZedThree
previously approved these changes
Jan 10, 2020
ZedThree
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a case where we needed
toFieldAligned()andfromFieldAligned()for aVector3D, so implemented them.