-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate report for Timers #1882
Conversation
this. Just convenience methods that can be useful for rough profiling etc.
* next: (243 commits) Ignore file copied by configure Fix fmt include path not getting expanded correctly Add option to use external fmt instead of bundled version Install fmt from subdirectory correctly Fix Chinese translated strings Fixes for locale DE Hardcode flags for non-PETSc Laplace in test Replace deprecated global flags with new flags for preconditioners Fix PETSc Laplace MAST grid test Add header file containing the wrapper Ran clang-format and added mpi_wrapper.hxx to CMakeLists.txt Ensured MpiWrapper initialised before mesh is created Add breaking change entry to changelog Add redundant out-of-line definitions for static Factory members Use fmt's positional arguments to avoid repeating variable Apply fmt fixes to i18n Apply fmt fixes to remaining tests and examples Use fmt for other printf formatting in bout++.cxx Use fmt to format timestamp Fix uses of output to use fmt formatting ...
Also: - remove the "current time" column - add comments
I've changed the columns to drop the current time and add mean time per hit:
Maybe the switch should be |
Would sorting by one of the columns be simple to do? e.g. sort by total time might be the most useful most of the time |
Use a subsection to avoid cutting off future optional features
I've changed the option to Also added a column with fraction of the largest time. Now looks like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, although I wrote some of this.
Adds two methods to
Timer
:getTotalTime
to see the total time elapsed for a timer (i.e. doesn't get reset withresetTime
)listAllInfo
generates a table reporting all the timers, like:Adds an option
write_final_timings
which prints the above table at the end of a simulation.I'm not so sure the "current time" column is particularly useful, probably a "mean time per hit" would be better. Also I'm not overly keen on the name
write_final_timings
at global scope, so suggestions welcome!