Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Petsc init/finialise not being idempotent #1922

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

ZedThree
Copy link
Member

Fixes #1916

The output.disable/enable thing is a little bit gross. Could solve that by add bool quiet arguments to PetscLib constructor and cleanup, although it wouldn't be possible to do so to the destructor.

Checked with PETSc git master and MPICH 3.2

@dschwoerer
Copy link
Contributor

If PetscLib would store the bool, it would be only needed in the constructor.

Anyway, this fixes the issue, thanks for the workaround as well as reporting this on all the other levels 👍

@ZedThree ZedThree merged commit d089454 into next Mar 2, 2020
@ZedThree ZedThree deleted the fix-mpich-petsc-bug branch March 2, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants