Fix possible data race in MsgStack::push() #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
added
bugfix
small-change
ZedThree
previously approved these changes
Mar 9, 2020
|
We currently only apply OpenMP to loops, so this would be fine. I don't believe we have plans to do any other kind of task sharing, so I would be happy making it |
single means we only get the message stack from one thread, which implies they should all be doing the same thing and precludes different tasks. We currently only apply OpenMP to loops, so this is fine.
|
I think we also need |
|
It should be |
Needed to be consistent with using BOUT_OMP(single) in MsgStack::push().
|
Yep |
ZedThree
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue noted by @d7919 here #1803 (comment)
Would it be better with a
BOUT_OMP(single)as suggested here #1803 (comment)?