Exclude corner cells in LaplaceXY #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
previously approved these changes
Mar 9, 2020
|
Lots of errors on Travis because they decided to handle quotes in environment variables differently for a couple of hours. |
|
Looks like I also broke test-yupdown |
I'm looking at that one. There's a small error just on the |
The HermiteSpline, MonotonicHermiteSpline and HermiteSplineOnlyZ interpolation classes were relying on the old behaviour of Mesh::communicateXZ(), which despite the name actually communicated also in y, and just did not calculate the parallel slices. To regain this behaviour, use Mesh::sendY() and Mesh::wait() directly. Corner cells of fx, fz, and fxz, which may actually be used, are now communicated correctly.
- use build_and_log - fix parallel transform input option - don't use MPIRUN
|
Fixed, and also fixed and tidied up test-yupdown-weights while I was at it. |
johnomotani
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this should've been in #1885 maybe. My bad, definitely a downside to breaking #1803 into separate PRs!
This is why half the PR tests are failing. Not sure why the other half are yet