Minor fixes for elm-pb and python tools #1958
Conversation
* Remove dependence on Bunch only partially tested. elm-pb plotting works now. * fix permissions on nc file * remove code with hardcoded filename, also no shebang was set * add missing she-bang to elm-pb script
|
Thanks! Is there supposed to be a To be honest, I think there's a ton of stuff in pylib we can just delete in v5. |
| @@ -30,8 +29,6 @@ def moment_xyzt( sig_xyzt, *args):#rms=None, dc=None, ac=None): | |||
| #; -AC (DC subtracted out), i.e., a function of (x,y,z,t) | |||
| #;------------------------------------------------------------------- | |||
There was a problem hiding this comment.
It wasn't changed in this PR, but since we're touching the methods here...
This moment_xyzt seems to be mis-named - it's actually using (t,x,y,z) (I guess this is due to a port from IDL to Python). It would be nice to change the names and comments so that they reflect the actual (t,x,y,z) behaviour.
There was a problem hiding this comment.
Sorry, but I would rather remove them.
I think what the function does is to simply to put actually in a library ...
There was a problem hiding this comment.
I don't have strong feelings about it. Given what @ZedThree said in the BUG meeting today about getting rid of stuff in the old pylib, I'd vote for leaving as is for now (get this PR merged), and remove stuff from pylib in a dedicated PR.
| if s == 4 : | ||
| nx = np.shape(var)[1] | ||
| ny = np.shape(var)[2] | ||
| nt = np.shape(var)[0] | ||
|
|
||
| result = np.zeros((nx,nt)) | ||
| for t in range (nt): | ||
|
|
||
| result[:,t] = surface_average(var[t,:,:,:], g, area=area) | ||
| result[:,t] = surface_average(var[t,:,:,:], grid, area=area) |
There was a problem hiding this comment.
I'd prefer to switch the result so it's result[t,x].
There was a problem hiding this comment.
I would rather remove it ... If you think this function is useful I'd do it though ...
Yes. I had |
Resolves #1071