Use custom main instead of PhysicsModel in test-communications #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids error from Pvode solver which checks whether anything is being evolved. Also generally neater. Also adds test-communications to the CMake build.
johnomotani
added
bugfix
small-change
ZedThree
previously approved these changes
Mar 23, 2020
dschwoerer
previously approved these changes
Mar 23, 2020
ZedThree
previously approved these changes
Mar 24, 2020
|
Failing on Travis because the python f-strings require 3.6, and Ubuntu 16 is stuck on 3.5. We could upgrade Travis to use Bionic (Ubuntu 18), which has python 3.6, but then we'd be dropping support for everyone else too. I'm not opposed to doing that, but we probably want some wider discussion. Please could you change this to use |
f-strings are only supported by Python>=3.6
ZedThree
approved these changes
Mar 24, 2020
|
Thanks @johnomotani ! 👍 |
|
Tests have passed, just not reported correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids error from Pvode solver which checks whether anything is being evolved - partial fix for #1982. Also generally neater not to use
PhysicsModelwhen we don't actually need time-evolution.Also adds
test-communicationsto the CMake build.Most of the lines changed are just whitespace due to a change of indentation in updating
test-communications.cxx.