Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include smaller "fmt/core.h" #2001

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Include smaller "fmt/core.h" #2001

merged 3 commits into from
Mar 31, 2020

Conversation

ZedThree
Copy link
Member

This should improve compilation times, as mostly fmt/core.h is sufficient:

fmt/format.h defines the full format API providing compile-time format string checks, output iterator and user-defined type support

Helps with #1979. Cuts compilation on Travis by ~20%!

@ZedThree ZedThree added the small-change Changes less than 100 lines - should be quick to review label Mar 30, 2020
@ZedThree ZedThree added this to the BOUT-5.0 milestone Mar 30, 2020
@ZedThree ZedThree merged commit 958f685 into next Mar 31, 2020
@ZedThree ZedThree deleted the include-fmt-core-only branch March 31, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwoerer dschwoerer dschwoerer approved these changes

Assignees
No one assigned
Labels
small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Milestone
BOUT-5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZedThree @dschwoerer