Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove checklib dependency from unit tests #2002

Merged
merged 1 commit into from
May 13, 2020
Merged

remove checklib dependency from unit tests #2002

merged 1 commit into from
May 13, 2020

Conversation

dschwoerer
Copy link
Contributor

This triggers unneeded rebuilds. It is not used anywhere else.

Should this go to master instead?

This triggers unneeded rebuilds. It is not used anywhere else
@ZedThree
Copy link
Member

It's also used here:

$(SOURCEC): checklib

CHANGED is:

CHANGED = $(shell find -f $(BOUT_TOP)/include $(BOUT_TOP)/src -type f \( -name \*.cxx -or -name \*.h \) -newer $(LIB) -print 2> /dev/null)

That should be .hxx not .h 🤦‍♂️

@dschwoerer
Copy link
Contributor Author

I noticed the .h as well. But it doesn't work anyway if only the hxx are changed, it doesn't trigger a rebuild of affected files. Should I remove it?

That is why the physics model is always rebuild -.-
Are you happy with removing that as well, or is that to confusing for physics model?
If so, I think it should be a separate PR / this PR should be renamed so that it ends up in the changelog.

@ZedThree ZedThree merged commit 345e35f into next May 13, 2020
@ZedThree ZedThree deleted the unit-test-faster branch May 13, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants