Without netcdf #2004
Merged
Without netcdf #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* next: (138 commits) Fix typo in help text [clang-format-command] fixes Update src/sys/boutexception.cxx Use C++ style casts Remove .split() call in boutcore.init() Improve generic factory docstring example Pass errorlist as kwarg Use `std::abs` to get correct overload Clang-format example fixes Reduce scope of some local variables in examples Fix reorder warning in examples Fix sign-comparison warnings in examples Remove some unused variables/parameters from examples Fix use of deprecated region enums Apply suggestions from code review Split creation of x, y, z arrays into method in BoutOptionsFile MMS test for parallel derivatives using ShiftedMetricInterp Remove now-redundant comment Extra comment about corner_zind modification Prefer 'x' and 'y' to 'i.x()' and 'i.y()' ...
ZedThree
reviewed
Jun 3, 2020
ZedThree
previously approved these changes
Jun 3, 2020
|
Tests are passing, just not getting reported correctly, again. The change to tools/pylib/boututils/datafile.py in cc61817 should maybe go into master and/or the boutdata repo too |
ZedThree
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
./configure --without-netcdf && make checkI found #2003 during this, but other tests are now passing / being skipped.
Depends on #2000 to avoid merge conflicts.