Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error if fields are not compatible #2012

Merged
merged 3 commits into from
Apr 6, 2020

Conversation

dschwoerer
Copy link
Contributor

Helps with debugging ...

Rather then failing with fields are not compatible, the error now
contains information about which part is not compatible, and what the
specific missmatched types are.
Copy link
Contributor

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for this, would have saved me a lot of trips through gdb!

@ZedThree
Copy link
Member

ZedThree commented Apr 6, 2020

Very nice, thanks @dschwoerer !

@ZedThree ZedThree merged commit 4b602d4 into next Apr 6, 2020
@dschwoerer dschwoerer deleted the verbose-field-compat branch December 11, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants