Travis: add Fedora job #2036
Travis: add Fedora job #2036
Conversation
There was a problem hiding this comment.
Cool, thanks @dschwoerer ! Always nice to test in more environments + more compilers! 馃槃
.travis_fedora.sh
Outdated
| cd | ||
| cd BOUT-dev | ||
| echo "starting configure" | ||
| time bash ./configure --with-petsc --enable-shared || cat config.log |
There was a problem hiding this comment.
Is bash really necessary here? configure is supposed to be very shell-agnostic!
Personally I'd prefer we use CMake here too!
There was a problem hiding this comment.
Put it there for debugging, removed it now.
First I need to get used to using CMake. Is there a way to get tab completion to work?
There was a problem hiding this comment.
Sure, that's reasonable! 馃槃
These files should probably be installed on your system somewhere: https://gitlab.kitware.com/cmake/cmake/-/tree/master/Auxiliary/bash-completion
I've only just discovered it and it seems to work quite well, so thanks for suggesting it!
Only slight annoyance is that it doesn't work with cmake . -B <build dir>, looks like you need to run cmake .. from the build directory for it to work
|
I think the issue is that you need to have run `cmake ..` in the past in
this directory. That makes it a bit of a pain ...
Also that breaks setting defaults based on other vars, as after the
first invocation they are already set, so the changed defaults aren't used.
So a workflow should probably be:
```
cmake || :
rm .* * ; cmake -D(tab)
```
I noticed only 2 flags are `BOUT_` prefixed - should they all start with
`BOUT_`. With tab completion cmake is so much easier to use 馃帀
|
|
Do you know which settings don't get updated? Most should be fine I think. Oh, plan was to actually namespace everything in #2027, evidently I've not done that yet. Will fix! |
|
On 5/26/20 2:33 PM, Peter Hill wrote:
Do you know which settings don't get updated? Most should be fine I think.
BOUT_USE_SYSTEM_FMT:BOOL=ON
BOUT_USE_SYSTEM_MPARK_VARIANT:BOOL=ON
both stay OFF if called with -DGIT_SUBMODULE=OFF even if the
externalpackages have been purged.
More generally, maybe we should first check whether fmt and
mpark.variant is available, and only if that fails use the bundled ones?
I suppose installing them if the are already present is calling for trouble.
Oh, plan was to actually namespace everything in #2027
<#2027>, evidently I've not
done that yet. Will fix!
Tjamls
|
|
Ah ok, think I've got that fixed with |
Add job for fedora 馃槂
It also adds a script to detect fedora, because one test was to slow.
I needed to change the detect travis script, because there was no un-versioned python command.