Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location checks to Div_par_K_Grad_par #2038

Merged
merged 1 commit into from
May 27, 2020
Merged

Add location checks to Div_par_K_Grad_par #2038

merged 1 commit into from
May 27, 2020

Conversation

bshanahan
Copy link
Contributor

Adds a location check to Div_par_K_Grad_par, which otherwise can result in an assertion error if outloc == CELL_DEFAULT.

@johnomotani johnomotani added the backport candidiate Does not break backward compatibility, so can be back-ported to v4.4 label May 27, 2020
johnomotani
johnomotani approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bshanahan!

@ZedThree ZedThree merged commit 1843ba1 into next May 27, 2020
@ZedThree ZedThree deleted the loc_div_par_k_grad_par branch May 27, 2020 16:04
@bshanahan bshanahan mentioned this pull request May 28, 2020
Closed
@ZedThree ZedThree mentioned this pull request Aug 4, 2021
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnomotani johnomotani johnomotani approved these changes

Assignees
No one assigned
Labels
backport candidiate Does not break backward compatibility, so can be back-ported to v4.4 bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bshanahan @johnomotani @ZedThree