Minor improvements and fixes to LaplaceIPT #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-included levels have zero-sized ar, br, cr arrays but were trying to index them
`all` can be local lambda, `tranpose` static and in anonymous namespace
Because Array(size_type) is not explicit, this assignment ends up changing the size of first_call to 1, via implicitly converting the bool to an int, and calling the copy-assignment operator. Also use std::fill to assign converged too
Also move to immediately before use
- Use Array/Matrix/Tensor::reallocate to set size of container - Use `1 << n` instead of `pow(2, n)` for integral types
ZedThree
commented
May 27, 2020
Comment on lines
225
to
233
| bool isGlobalFlagSet(int flag) { | ||
| return (global_flags & flag) != 0; | ||
| } | ||
| bool isInnerBoundaryFlagSet(int flag) { | ||
| return (inner_boundary_flags & flag) != 0; | ||
| } | ||
| bool isOuterBoundaryFlagSet(int flag) { | ||
| return (outer_boundary_flags & flag) != 0; | ||
| } |
There was a problem hiding this comment.
These helper functions might actually be more generally useful, and could maybe be moved to Laplace base class? Could then make the flag members private rather than protected
And I've just noticed these methods should all be const too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of important fixes, and some other minor changes because I can't help myself:
is_diagonally_dominantwhere non-includedlevels were taking partconst&Level::initoverloads constructorsclang-tidy