Use C++ style casts #2048
Merged
Use C++ style casts #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/clang-format |
|
Just FYI, the clang-format command did work, but there was nothing to do. Maybe I should add some feedback for that case? |
ZedThree
reviewed
Jun 1, 2020
Co-authored-by: Peter Hill <zed.three@gmail.com>
|
/clang-format Did the first one work? On the second there are emojis, so that seems to have worked, but the first one not? Also I think the review with |
ZedThree
approved these changes
Jun 2, 2020
|
I don't think the first one triggered it. The second one did trigger it but I think the syntax error fooled it, so it errored. The 🎉 emoji on the third one indicates it finished successfully, although it says it was from me, rather than the bot! Glad you think it's useful! I'll see if there's any polish can be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/clang-format
Part of #2025
Doesn't change anything, just makes it more explicit.