Fix current Travis failures in next #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2089 This is necessary due to a change in PETSc 3.11: > Previously the KSP Chebyshev implementation always did one more > iteration than requested. For example -ksp_max_it 2 resulted in 3 > Chebyshev iterations. This has been corrected. Due to this correction > your solver may seem to converge more slowely than it previous > has. Note that the multigrid solvers (PCMG, PCGAMG, PCML) used by > default Chebyshev (with 3 actual steps) in their smoother, thus the > multigrid solvers will now have seemingly different convergence rates > since they will now use only 2 actual steps. To reproduce previous > behavior change the number of smoother iterations to match the > previous actual amount, this can be done with for example > -mg_levels_ksp_max_it 3 (or -prefix_mg_levels_ksp_max_it 3 if the KSP > object has a prefix). This was also the cause of #2034, which was fixed in #2051 We should be able to set the default value with `PCMGSetNumberSmooth`, but this requires us to call `PCMGSetLevels` first, but we don't have the information to do that when setting up the solver. We also can't set `mg_levels_ksp_max_it` as a PETSc option in the solver, because that needs to go to the `PetscLib` instance. Therefore, we need to either set `mg_levels_ksp_max_it` in the tests, or adjust the tolerance for the tests.
Some problem with OPENBLAS-OPENMP causing test results to be dependent on number of OpenMP threads
This fixes an issue where setuptools or cython was using inconsistent compiler and linker
ZedThree
added
bugfix
small-change
johnomotani
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2089