Handle FieldPerps in Datafile::varAdded() and Datafile::varPtr() (next) #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a variable to the output with an existing name is not allowed unless the variable is the same one that was added the first time.
|
Added a test of attributes in I don't think we actually test the legacy netcdf interface, but if we do the tests will fail. It might not be a bad thing to fail and warn any users who are using legacy netcdf that there might be odd issues if they try to read netCDF4 files? We'd need to check in the test if it is using legacy netcdf in that case... |
* next: (31 commits)
Make sure test-restart-io sets exit code correctly on failure
Don't read/write FieldPerps in guard cells
Use last boundary point for global y-index in restart IO test
Better fix for reading/writing FieldPerp index
Rename *local -> *global argument in mesh index routines
Remove deprecated YLOCAL() in examples/laplace-petsc3d
Fix case-sensitivity of __contains__()
__eq__() comparison operator for BoutOptions()
Use no boundary form of global index conversion in FieldPerp I/O
Use more consistent global index when writing/reading `FieldPerp`s
Add Mesh::getLocal{X,Y,Z}Index{NoBoundaries} methods
install python3-h5py on travis@fedora
Remove unnecessary hardcoding of dump_format in test-invpar
CMake: Add missing requirement on PETSc for AMG test
Require netCDF for some tests
Use global mesh/dump in test-io_hdf5
Some tidying up to test-restarting
Enable HDF5 in all Travis jobs
Enable some HDF5-specific tests in default test set
Fix bug in DataFormat::writeFieldAttributes with FieldPerp
...
|
I merged next in locally, and |
yindex is now on first grid cell if yindex_global not present in grid file
johnomotani
commented
Sep 28, 2020
ZedThree
previously approved these changes
Sep 28, 2020
ZedThree
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix from #2093 into
next.