Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in tests/MMS/elm-pb #2137

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Fix errors in tests/MMS/elm-pb #2137

merged 2 commits into from
Nov 8, 2020

Conversation

johnomotani
Copy link
Contributor

Updates to be compatible with BOUT++ v5.0. Now compiles and runs.

Could do with more updates to remove deprecated functions, and possibly replace the Grad_parP method with the library version.

Updates to be compatible with BOUT++ v5.0
@johnomotani
Copy link
Contributor Author

Test still running on Marconi to see if output is correct...

The MMS/elm-pb test does not pass, so should not have renamed
runtest.broken
@johnomotani
Copy link
Contributor Author

The test now runs, but does not pass. Errors are increasing if anything up to n=32

Bp0 = 4.444444e-02
psi width = 1.777778e-03
Making MMS elm-pb test
Grid file 'grid8.nc' already exists
  Running with  MZ=8 grid=grid8.nc
getmpirun: using the default mpirun -np
P : l-2 0.448528 l-inf 1.844185
Psi : l-2 0.007161 l-inf 0.018150
U : l-2 4.481064 l-inf 25.520997
Grid file 'grid16.nc' already exists
  Running with  MZ=16 grid=grid16.nc
getmpirun: using the default mpirun -np
P : l-2 0.361313 l-inf 2.253608
Psi : l-2 0.007330 l-inf 0.019226
U : l-2 8.755153 l-inf 52.830942
Grid file 'grid32.nc' already exists
  Running with  MZ=32 grid=grid32.nc
getmpirun: using the default mpirun -np
P : l-2 0.406318 l-inf 2.436382
Psi : l-2 0.007367 l-inf 0.019666
U : l-2 11.800941 l-inf 116.680718
Grid file 'grid64.nc' already exists
  Running with  MZ=64 grid=grid64.nc
getmpirun: using the default mpirun -np

and the n=64 case fails to complete with At t = 0.000530184, mxstep steps taken before reaching tout.
Could fix that error, but already takes 5 hours to run the test as far as I did, and I increased the processor numbers used up to 128. So I think this test needs more attention than I have time to give it...

@ZedThree
Copy link
Member

ZedThree commented Nov 6, 2020

These tests are both tricky and fragile. I think these changes are worth merging at any rate

@johnomotani johnomotani merged commit 3b3eb25 into next Nov 8, 2020
@johnomotani johnomotani deleted the mms-elm-pb-fixes branch November 8, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants