Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPT feature branch with code used in study #2140

Merged

Conversation

JosephThomasParker
Copy link
Contributor

This PR pushes the code that was actually used in our manuscript on the UKAEA pinboard into the feature branch.

The changes relative to next+ipt are:

  • Use a single PVODE-like error check, error = residual/(rtol*soln + atol) < 1 instead of separate checks on rtol and atol.
  • Do a convergence check before doing any work. This saves work when calling this solver inside an iterative time advance, in which case we can sometimes start in a "converged" state.
  • Revert a function encapsulation that caused segfaults (I didn't get a chance to properly investigate this).

@JosephThomasParker JosephThomasParker changed the title Feature/ipt+new error+bugfix+allow zero loops Update IPT feature branch with code used in study Nov 10, 2020
@bendudson bendudson merged commit faaad42 into feature/ipt+next Dec 14, 2020
@bendudson bendudson deleted the feature/ipt+new-error+bugfix+allow-zero-loops branch December 14, 2020 22:31
@ZedThree ZedThree mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants