Check DataFile grid sizes match those in existing mesh #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZedThree
added
bugfix
small-change
bendudson
reviewed
Nov 18, 2020
| namespace { | ||
| // Read a value from file and check it matches reference_value, throw if not | ||
| void checkGridValue(DataFormat* file, const std::string& name, | ||
| const std::string& filename, const int reference_value) { |
There was a problem hiding this comment.
Makes no different to the signature, but the local variable is const :)
johnomotani
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Looks good to me. Would have told me exactly what the problem was that led me to open #2141
johnomotani
added
the
backport candidiate
|
Failing test is just Fedora build that we fixed today |
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2141