-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use FieldPerp in Options #2152
Conversation
Necessary to add FieldPerp to variant in Options
Needed to add FieldPerp to Options
Move implementation from DataFormat methods to FieldPerp
Allows storing `FieldPerp` in `Options`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I'm not at all familiar with OptionsNetCDF.
Also check that y-indices match in operator==
@bendudson Would you mind have a quick glance over the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZedThree ! Looks good to me.
We've moved from travis-ci.org to .com, so the failed PR test was restarted, but on .com which doesn't clear the .org version... Basically all tests have passed, we've just got an old notification sticking around. This is likely to the be the case with a few open PRs |
I've started work on trying to completely replace use of
DataFile
withOptionsNetCDF
. In order to prevent that PR from being way too big, I'm trying to split it into smaller chunks. This is one necessary part that is useful even if we decide not to useOptionsNetCDF
and could probably be backported?This PR actually has a couple of other features itself:
FieldPerp::getGlobalIndex
,FieldPerp::setIndexFromGlobal
-- moved code fromDataFormat
methods toFieldPerp
methodsOptions::hasAttribute
to check existence of attributevs