I/O for std::vector<int> and std::string #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_output() was duplicated in test-io_hdf5.
Only affects parallel=true case, which does not work anyway, so not a serious bug.
Previously, although the method had lx, ly, lz arguments, the 'counts' vector in write_rec(int*, ...) was hard-coded to length 1. This only allows writing a (time-dependent) scalar int variable. 'counts' should be length 4, with shape (1, lx, ly, lz).
johnomotani
added
feature
backport candidiate
ZedThree
approved these changes
Nov 25, 2020
This was referenced Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of #2150 removing support for
std::vector<char>.Closes #2150.