Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #2156

Merged
merged 15 commits into from
Dec 1, 2020
Merged

Migrate to GitHub Actions #2156

merged 15 commits into from
Dec 1, 2020

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Nov 27, 2020

I've disabled Travis for the time being, rather than delete the .travis.yml, as I want to check this runs the coverage tests on the PR correctly without Travis running at the same time.

This is going into next -- I'm not sure if the action becomes available in all branches.

I've also tweaked the jobs a little bit, so they're not exactly the same as on Travis. Most are now running on ubuntu-18.04 (Travis is all 16.04), except the CMake one is on 20.04.

It doesn't seem to be any faster than Travis, which is a little bit of a shame.

EDIT: Looks like the coverage jobs aren't running, so that'll be a fun job for Monday.

[skip travis] This will eventually replace Travis

Just two builds to check the matrix works as intended
For some reason, installing python3-h5py broke running mpiexec from
Python using subprocess in ubuntu-20.04. I do not understand why, but
this was definitely the cause
@ZedThree ZedThree added the tests label Nov 27, 2020
@johnomotani
Copy link
Contributor

This is going into next -- I'm not sure if the action becomes available in all branches.

I think the actions run on a PR are the ones in the .github/workflows directory in that branch. If I remember right I've been debugging them on other repos with pushes to a branch - which is the other way around but I suspect means actions are only available on branches that have merged the .github/workflows changes.

@ZedThree
Copy link
Member Author

ZedThree commented Nov 30, 2020

Coverage job still not running on the PR build... think I'll need to investigate in a fork so as to not spam this repo!

I've deleted the .travis.yml file and re-enabled Travis so it will run on other branches until this gets merged into them.

github.base_ref doesn't include 'refs/heads/' while github.ref does
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZedThree
Copy link
Member Author

🤦 Ignore all that, meant to push those debugging commits to my fork

@ZedThree
Copy link
Member Author

ZedThree commented Dec 1, 2020

Coverage job now working, I've also added a clang-tidy job which comments directly on the PR if it finds any issues.

Assuming that all the tests now actually run and pass, this is ready to go in. As it gets merged into other branches, they'll switch over from Travis to GitHub Actions. I've set these tests to be required, but I think I'll have to undo that for the time being, otherwise it's going to be a little confusing as they won't run on other branches

@ZedThree ZedThree merged commit 708c718 into next Dec 1, 2020
@ZedThree ZedThree deleted the migrate-github-actions branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants