Fix shiftOutput #2157
Merged
Fix shiftOutput #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an error to call toFieldAligned on a Field that is already aligned. When shiftOutput==true, add another condition so we skip calling toFieldAligned() if the field is already aligned.
When shiftOutput is true, Field3D and FieldPerp variables are transformed to field-aligned form before saving their data. Therefore the direction_y attribute of the saved field should be 'Aligned', rather than matching the original variable.
johnomotani
added
bugfix
backport candidiate
ZedThree
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs:
shiftOutputwas set allField3Ds andFieldPerps would be passed totoFieldAligned()before being written. If an aligned field was added to the output, it would have been too, but this is an error. Add an extra check to skiptoFieldAligned()for aligned fields.shiftOutput. WhenshiftOutputis set, allField3Ds andFieldPerps should havedirection_y = "Aligned"in the output files.