Support location in Mesh::get() #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to be able to request a Field at a certain location from Mesh::get() - when the grid data comes from input file expressions, these can now be evaluated at the correct location. Note: includes a fix for GridFromOptionsTest::CoordinatesYlowInterp so it now actually interpolates to CELL_YLOW, not CELL_XLOW.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bendudson
approved these changes
Dec 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to be able to request a Field at a certain location from Mesh::get() - when the grid data comes from input file expressions, these can now be evaluated at the correct location. This PR adds a
CELL_LOC locationargument to theFieldversions ofMesh::get(), and uses it inCoordinates. Makes it possible to use expressions for things likemesh:g_11_ylow, etc.Arguably a bugfix - input file expressions support staggering, so I expected
GridFromOptionsto support it too, but we were actually evaluating atCELL_CENTREand then callingvar.setLocation(location).I think I need this to fix
test-twistshift-staggeredin #2179.