Minor FCI improvements #2201
Merged
Minor FCI improvements #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we construct the FCI transform _during_ the construction of Coordinates, we can't call `Mesh::getCoordinates` in the `FCIMap` constructor. An alternative workaround would be to call `Mesh::get(dy)` instead, but the implemented method is more explicit
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i/k_cornerandt_x/zstuff is no longer used so can just goBOUT_FORBOUT_FOR_SERIALas it's got avector.push_backin the loop and I suspect that's not thread safedyto avoid null-dereferenceCoordinatesconstructor, which means we can't callMesh::getCoordinates. Instead, pass indy(It's a bit easier to view the diff if you select "hide whitespace changes")