Next coordinates sigma y #2203
Merged
Next coordinates sigma y #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep track of correct signs for both x,y,z and x,eta,z coordinates. This commit goes through 'Differential operators in field-aligned coordinates', 'J x B in field-aligned coordinates' and 'Parallel current' sections.
ZedThree
requested changes
Jan 8, 2021
bendudson
reviewed
Jan 8, 2021
Co-authored-by: Peter Hill <zed.three@gmail.com>
Co-authored-by: Ben Dudson <bd512@york.ac.uk> Co-authored-by: Peter Hill <zed.three@gmail.com>
ZedThree
approved these changes
Jan 12, 2021
|
LGTM 👍 I'll let Ben double-check and merge it. Failing tests are because base branch needs |
bendudson
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for some signs, etc. in the Coordinates documentation. Proposed addition to #2165.
It turned out to be possible to check all the places where there should be a sigma_Btheta or sigma_y by considering what sign flips should happen if the direction of the magnetic field was reversed (see footnote in Curvature section).
I haven't double checked these changes - @bendudson @ZedThree could you please have a look?