Remove HDF5 support #2208
Merged
Remove HDF5 support #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
added
the
breaking change
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I'm on-board with doing this now. Do we also want to remove legacy/parallel netCDF at the same? I say that realising we just merged a PR fixing the legacy netCDF. We could also remove |
|
Yes I think this is a good idea: I don't think hdf5 has really been used much. Legacy NetCDF can probably be kept for now, but parallel NetCDF I don't think works, and certainly isn't used. |
|
I'd support keeping legacy NetCDF around for the moment. I've been using it to avoid linking issues recently... |
ZedThree
approved these changes
Feb 4, 2021
|
I'm going to merge this manually in order to add a line to the breaking changes in CHANGELOG without triggering needless CI runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDF5 support is not planned for v5. Remove now to get rid of the effort required to maintain support?