-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonicalise input files #2218
Canonicalise input files #2218
Conversation
That is, allow just fixing whitespace etc.
Basically, remove extra whitespace, add whitespace around assignments, put subsections in order, convert floating point numbers to common format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. A few small niggles to do with deleting (or not) commented-out options.
Auto-tidy of input files removed some empty sections but left commented-out options "orphaned"
Meant to try out the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few extra orphaned lines to remove.
Lovely, thanks @johnomotani ! |
Sorry, this is a horrible PR. In order to apply other input file fixes more cleanly in #2210, first "canonicalise" the input files:
preserving relative order
value will not change
Essentially just a round-trip of input file -> python
BoutOptions
-> input file, with no other changes.Viewing this PR with "hide whitespace" enabled will be useful.
The majority of the changes are like:
This PR does mean any future input file changes will have much cleaner diffs!