Zoidberg changes #2219
Merged
Zoidberg changes #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa isn't using numpy, so arrays are huge in memory. Chunking the download hugely helps reducing memory usage.
* total count was off * local count was off * move to end and add plus one to ensure we always end with 100% Previously it was sometimes 99.99%, which is confusing if it crashes afterwards. * float is not needed, we are using python3, division defaults to true_div
* This seems to help with numerical convergence.
|
Thanks @dschwoerer ! Black formatting definitely appreciated, and the changes sound good |
|
One test is timing out, quite annoying. Rather than rerun all the tests (github still won't let you just rerun one!), I'll merge this into 3D metrics branch and let it rerun there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to zoidberg.
I also run black (7915e1a ) - if that is not appreciated I can push without that commit ...