ny_inner label misleading in topology schematic #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've cancelled the CI (apart from readthedocs build) since this PR is only documentation (and I forgot to add a |
|
I think the filename should be Is it possible to crop the SVG a bit too? Otherwise, looks good! |
Most consistent label is the number of the last grid point, i.e. nx-1, ny_inner-1, ny-1 instead of nx, ny_inner, ny. Label at upper outer divertor definitely should not be ny_inner+1. [skip ci]
johnomotani
force-pushed
the
topology_schematic-fix
branch
from
e52793d
to
0a6411f
Compare
|
Thanks @ZedThree, I've made those changes. I've force-pushed the branch to avoid possibly adding more binary files to the history. |
ZedThree
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qian Xia pointed out that the
n_innerlabels on the topology schematic are misleading. The label at upper outer divertor definitely should not ben_inner+1. This PR has a 'corrected' version of the figure, and also adds the .svg file (updated version of the one I got from @lukeeasy) in case someone wants to edit it in future (can be edited with inkscape).I've changed
n_innertony_innerbecause I think it's clearer.I think the most consistent label for the outer boundaries is the number of the last grid point, i.e.
nx-1,ny_inner-1,ny-1instead ofnx,ny_inner,ny, so I've updated that too.